style tool was Re: [PATCH 33.0 1/5] LEON: updated AMBA PnP API

Joel Sherrill joel.sherrill at OARcorp.com
Mon Apr 16 09:21:45 CDT 2012


The tool is important but the style rules are more critical.

Knowing what indent or astyle options match the RTEMS style
and where the tools fall short is important. That way
if another tool comes along or someone wants to
configure an IDE or editor to match the RTEMS style,
then it is a known set of rules.

On 04/16/2012 08:10 AM, Sebastian Huber wrote:
> On 04/16/2012 03:01 PM, Ralf Corsepius wrote:
>   >  On 04/16/2012 02:33 PM, Sebastian Huber wrote:
>   >>  On 04/16/2012 10:23 AM, Daniel Hellstrom wrote:
>   >>>>  Second is the indentation. We usually use 2 spaces per indent level
>   >>>>  while this code uses 6 or so.
>   >>>  Yes, it have hard TAB = 8 spaces. I believe I have asked before about
>   >>>  indentation, and I've got the impression that it doesn't really matter
>   >>>  as it is
>   >>>  consistent within the file. At least it is easier to go from hw-tab to
>   >>>  soft,
>   >>>  and of course I agree that all files should aim to have the same
>   >>>  coding-style.
>   >>>  I will update the patches and come back.
>   >>
>   >>  Maybe it makes sense to define a set of astyle
>   >>
>   >>  http://astyle.sourceforge.net/
>   >
>   >  Why are you proposing this tool?
>
> It was mentioned recently on the GCC mailing list and looks good (I only looked
> briefly at the documentation).
>
>   >  It's far from being standard or widely adopted. The standard tool to enforce a
>   >  coding style would be indent.
>
> I never was happy with the output.
>


-- 
Joel Sherrill, Ph.D.             Director of Research&   Development
joel.sherrill at OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
     Support Available             (256) 722-9985




More information about the rtems-devel mailing list