[Bug 1802] smp support for i386

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Fri May 20 11:52:10 CDT 2011


https://www.rtems.org/bugzilla/show_bug.cgi?id=1802

Gedare <giddyup44 at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |giddyup44 at yahoo.com

--- Comment #1 from Gedare <giddyup44 at yahoo.com> 2011-05-20 11:52:10 CDT ---
why not integrate appcpustart.S with start.S as is done with the leon?

+pc386_delay:
+_pc386_delay:
IIRC this type of routine was the reason for an rtems_bsp_delay in the first
place.

smp-imps.c:
+#define __RTEMS_VIOLATE_KERNEL_VISIBILITY__
What is this for?

+/* base address of applciation processor reset code at 0x70000 */
typo s/applciation/application

+extern char _binary_appstart_bin_start[];
+extern char _binary_appstart_bin_size[];
+
+extern void _pc386_delay(void);
These should probably be declared in smp-imps.h?

There are a number of printks that should be #ifdef'd out for production.

+int
+imps_probe(void)
namespace?

+/*
+ *  RTEMS SMP BSP Support
+ */
Everything below / including this should probably go in separate file(s)

smp-imps.h:
Are the exported globals required?

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.


More information about the rtems-bugs mailing list