[Bug 1576] SD card CRC checks: should enable CRCs

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Mon Jun 21 10:14:03 CDT 2010


https://www.rtems.org/bugzilla/show_bug.cgi?id=1576

Arnout Vandecappelle <arnout at mind.be> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #807 is|0                           |1
           obsolete|                            |

--- Comment #2 from Arnout Vandecappelle <arnout at mind.be> 2010-06-21 10:14:02 CDT ---
Created an attachment (id=808)
 --> (https://www.rtems.org/bugzilla/attachment.cgi?id=808)
sdcard: ignore CRC7 of 0x7f and use CRC_ON_OFF command during initialization

(In reply to comment #1)
> (In reply to comment #0)
> > Created an attachment (id=807)
 --> (https://www.rtems.org/bugzilla/attachment.cgi?id=807) [details] [details]
> > sdcard: ignore CRC7 of 0x7f and use CRC_ON_OFF command during initialization
> > 
> > In bug 1569, I forgot to use the 'enable CRC checks' command.  Also, CRC of
> > 0x7F should be ignored (means don't care).
> > 
> > Attached patch fixes this.
> 
> You assign something to rv, but don't check this value.  Is this intentional?

It's done is a couple of other places in spi-sd-card.c.  Ignoring the return
value is definitely intentional: nothing else depends on its success, and I'm
not sure if the command is supported by all SD and MMC cards.  But it's indeed
probably better to explicitly ignore the return value.  This is done in
attached updated patch.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.


More information about the rtems-bugs mailing list