[Bug 1636] Refactor Rate Monotonic Manager into a generic Periodic Manager

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Sat Aug 7 17:27:51 CDT 2010


https://www.rtems.org/bugzilla/show_bug.cgi?id=1636

--- Comment #7 from Joel Sherrill <joel.sherrill at oarcorp.com> 2010-08-07 17:27:48 CDT ---
Comments below

+ Patch is out of date for score/Makefile.am.  No big deal.  I fixed that.

+ missing } for C++ in rtems/.../periodic.h

+ no user documentation.  But not important see next.

+ If I am right, I think you rename rate_monotonic_period_XXX
to rate_periodic_XXX and I can't accept that part of the patch. This
would break API compatibility and although it can be argued that
the rate monotonic name obscures the fundamental nature of the periodic
blocking service being implemented, it is really the theoretical reason
this manager exists.  So can your periodicXXX be moved to ratemonXXX and
fixed?

+ You can't have objects with Ids in the score.  They all have to take
pointers.  You combine score handlers with object control structure to
create API level objects.  So this periodic thing in the core needs to
change to more of a support service.  I think it is close.  I suspect 
you just need to remove the Object_Control field from the structure
and add it at the ratemon level.  You never really used the id anyway
as best I can tell.

+ I think most of the style issues mentioned in the modular scheduler
PR apply here.

I really like the idea of adding a "periodic blocking service" to the 
score.  But use it to simplify ratemon_xxx and don't rename the current
API.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.


More information about the rtems-bugs mailing list